Messages in this thread | | | From | "Lad, Prabhakar" <> | Date | Tue, 30 Aug 2022 09:28:05 +0100 | Subject | Re: [PATCH] dt-bindings: mmc: renesas,sdhi: Add iommus property |
| |
Hi Geert,
Thank you for the review.
On Tue, Aug 30, 2022 at 8:06 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Prabhakar, > > Thanks for your patch! > > On Mon, Aug 29, 2022 at 11:43 PM Lad Prabhakar > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > The SDHI block on Renesas R-Car and RZ/G2 SoC's make use of IOMMU. > > blocks ... SoCs > > > This patch fixes the below dtbs_check warnings: > > arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h-ex-idk-1110wr.dtb: mmc@ee100000: Unevaluated properties are not allowed ('iommus' was unexpected) > > From schema: Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > > +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > > @@ -77,6 +77,9 @@ properties: > > > > clock-names: true > > > > + iommus: > > + maxItems: 1 > > I would insert iommus below dma-names, as iommus belongs to dmas, > logically (yes I know dmas is not used on R-Car Gen3 and RZ/G2, as > SDHI has its own DMA controller). > Ok, I will move it after dmas along with an updated commit message and send a v2.
Cheers, Prabhakar
| |