Messages in this thread | | | Date | Tue, 30 Aug 2022 19:47:25 -0700 | Subject | Re: [PATCH] RDMA/srp: Set scmnd->result only when scmnd is not NULL | From | Bart Van Assche <> |
| |
On 8/30/22 18:47, yangx.jy@fujitsu.com wrote: > diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c > index 7720ea270ed8..528cdd0daba4 100644 > --- a/drivers/infiniband/ulp/srp/ib_srp.c > +++ b/drivers/infiniband/ulp/srp/ib_srp.c > @@ -1961,6 +1961,7 @@ static void srp_process_rsp(struct srp_rdma_ch *ch, struct srp_rsp *rsp) > if (scmnd) { > req = scsi_cmd_priv(scmnd); > scmnd = srp_claim_req(ch, req, NULL, scmnd); > + scmnd->result = rsp->status; > } else { > shost_printk(KERN_ERR, target->scsi_host, > "Null scmnd for RSP w/tag %#016llx received on ch %td / QP %#x\n", > @@ -1972,7 +1973,6 @@ static void srp_process_rsp(struct srp_rdma_ch *ch, struct srp_rsp *rsp) > > return; > } > - scmnd->result = rsp->status; > > if (rsp->flags & SRP_RSP_FLAG_SNSVALID) { > memcpy(scmnd->sense_buffer, rsp->data +
Since there is a 'return' statement in the else branch, I don't see how this patch can make a difference?
Thanks,
Bart.
| |