Messages in this thread | | | Date | Wed, 31 Aug 2022 09:22:03 +0800 | Subject | Re: [RFC PATCH] blk-mq: change bio_set_ioprio to inline | From | Liu Song <> |
| |
On 2022/8/31 08:59, Jens Axboe wrote: > On 8/30/22 6:42 PM, Liu Song wrote: >> On 2022/8/30 21:59, Jens Axboe wrote: >>> On 8/30/22 3:45 AM, Liu Song wrote: >>>> From: Liu Song <liusong@linux.alibaba.com> >>>> >>>> Change "bio_set_ioprio" to inline to avoid calling overhead. >>> Let's not try to 2nd guess the compiler here. Most things that are >>> marked inline should not be. >> Agree, I think there is something wrong with the commit log written here, >> it should be expected to reduce the call overhead, bio_set_ioprio seems >> to be appropriate to use inline. > I'm sure it's worth inlining, but did you check if it isn't already? > If it's small I'd fully expect the compiler to inline it already, > without needing to add things to do so. > It is indeed possible, thanks for your reply.
Thanks
| |