Messages in this thread | | | Date | Tue, 30 Aug 2022 21:22:30 -0300 | From | Jason Gunthorpe <> | Subject | Re: [PATCH 10/15] vfio/fsl-mc: Use the new device life cycle helpers |
| |
On Sun, Aug 28, 2022 at 01:10:32AM +0800, Kevin Tian wrote: > From: Yi Liu <yi.l.liu@intel.com> > > Export symbol of vfio_release_device_set() so fsl-mc @init can handle > the error path cleanly instead of assuming certain vfio core API can > help release device_set afterwards.
I think you should leave it as is, the "device_set" cleanup is just something handled completely internally to vfio
If ops->init fails then we expect the core code to clean the device_set, and it does because it calls vfio_init_device() already.
Having a single weirdly placed release in the driver is pretty confusing, IMHO.
Jason
| |