Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Tue, 30 Aug 2022 21:58:14 +0200 | Subject | Re: [PATCH v1 tty-next 1/2] 8250: microchip: pci1xxxx: Add driver for the quad-uart function in the multi-function endpoint of pci1xxxx device. |
| |
Hi Kumaravel,
On Tue, Aug 30, 2022 at 8:01 PM Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com> wrote: > pci1xxxx is a PCIe switch with a multi-function endpoint on one of its > downstream ports. Quad-uart is one of the functions in the > multi-function endpoint. This driver loads for the quad-uart and > enumerates single or multiple instances of uart based on the PCIe > subsystem device ID. > > Signed-off-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>
Thanks for your patch!
> --- /dev/null > +++ b/drivers/tty/serial/8250/8250_pci1xxxx.c
> +static struct pci_driver pci1xxxx_pci_driver = { > + .name = "pci1xxxx serial", > + .probe = pci1xxxx_serial_probe, > + .remove = pci1xxxx_serial_remove, > + .id_table = pci1xxxx_pci_tbl, > +}; > + > +module_pci_driver(pci1xxxx_pci_driver);
> --- a/drivers/tty/serial/8250/Kconfig > +++ b/drivers/tty/serial/8250/Kconfig > @@ -528,6 +528,15 @@ config SERIAL_8250_TEGRA > Select this option if you have machine with an NVIDIA Tegra SoC and > wish to enable 8250 serial driver for the Tegra serial interfaces. > > +config SERIAL_8250_PCI1XXXX > + tristate "Microchip 8250 based serial port" > + depends on SERIAL_8250
As this is a PCI driver, I guess it should depend on PCI (|| COMPILE_TEST)?
> + help > + Select this option if you have a setup with Microchip PCIe > + Switch with serial port enabled and wish to enable 8250 > + serial driver for the serial interface. This driver support > + will ensure to support baud rates upto 1.5Mpbs.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |