lkml.org 
[lkml]   [2022]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH -next 1/4] spi: mockup: Add SPI controller testing driver
On Fri, Aug 26, 2022 at 02:43:38PM +0000, Wei Yongjun wrote:

> @@ -0,0 +1,221 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * SPI controller Testing Driver
> + *
> + * Copyright(c) 2022 Huawei Technologies Co., Ltd.
> + */
Please make the entire comment a C++ one so things look more
intentional.

> + master = spi_alloc_master(&pdev->dev, sizeof(struct mockup_spi));
> + if (!master) {
> + pr_err("failed to alloc spi master\n");
> + return -ENOMEM;
> + }

Please use the new _controller() API, we're trying to remove the
use of outdated terminology.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-08-30 21:12    [W:0.272 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site