Messages in this thread | | | Date | Tue, 30 Aug 2022 19:33:03 +0100 | From | Matthew Wilcox <> | Subject | Re: [PATCH v2 1/2] libfs: Introduce tokenize_user_input() |
| |
On Thu, Aug 25, 2022 at 06:48:32PM +0200, Cezary Rojewski wrote: > Add new helper function to allow for splitting specified user string > into a sequence of integers. Internally it makes use of get_options() so > the returned sequence contains the integers extracted plus an additional > element that begins the sequence and specifies the integers count. > > Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com> > --- > fs/libfs.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ > include/linux/fs.h | 1 +
This really has nothing to do with filesystems. Surely string_helpers.[ch] is the appropriate place for this code? Also get_options() should probably move its prototype from kernel.h to string_helpers.h.
| |