lkml.org 
[lkml]   [2022]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 2/9] dt-bindings: riscv: microchip: document the aries m100pfsevp
Date
On 30/08/2022 18:47, Krzysztof Kozlowski wrote:
> On 30/08/2022 20:35, Conor.Dooley@microchip.com wrote:
>> On 30/08/2022 18:30, Krzysztof Kozlowski wrote:
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>>
>>> On 30/08/2022 19:59, Conor.Dooley@microchip.com wrote:
>>>>>> w dts were
>>>>>> needed so that the gpio-hog could be set correctly. Out of curiosity, I can
>>>>>> have the same compatible in multiple devicetrees right? In that case, it
>>>>>> would just be "aries,m100pfsevp" here and I could put that in both?
>>>>>> Would make things easier..
>>>>>
>>>>> Depends, but I would say for this case rather not. The compatible should
>>>>> identify the board. If the boards are different, one compatible should
>>>>> not identify both of them. Imagine U-Boot (or something else) trying to
>>>>> match the DTS.
>>>>
>>>> It is the same board though, the way the bootloader works is that if it
>>>> detects an SD-card it will use that to boot from, and if not will fall back
>>>> to the emmc.
>>>
>>> Wait, I might miss that part. So this is exactly the same hardware with
>>> the same SoM/SoC, same eMMC and SD card, except that one has plugged
>>> this SD card (as it is hot-pluggable)?
>
> Then two thoughts:
> 1. It is indeed one compatible because it is exactly the same hardware
> (I don't consider plugged SD card as part of it, just like plugged USB).

Cool.

>
> 2. Then I don't think you should have two boards in the kernel. It's
> fine if bootloaders have two of them or to store an overlay in the
> kernel or somewhere. But two boards for the same board differing by
> hot-plug setup is not for Linux kernel.

Fine by me too. Easy enough to sort that out in u-boot or w/e (and do
whatever suits in a vendor tree).

Thanks Krzysztof :)


\
 
 \ /
  Last update: 2022-08-30 19:59    [W:0.048 / U:1.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site