lkml.org 
[lkml]   [2022]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.10 01/16] firmware: dmi: Use the proper accessor for the version field
    Date
    From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

    [ Upstream commit d2139dfca361a1f5bfc4d4a23455b1a409a69cd4 ]

    The byte at offset 6 represents length. Don't take it and drop it
    immediately by using proper accessor, i.e. get_unaligned_be24().

    [JD: Change the subject to something less frightening]

    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Signed-off-by: Jean Delvare <jdelvare@suse.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/firmware/dmi_scan.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c
    index d51ca0428bb82..bd43277dbb878 100644
    --- a/drivers/firmware/dmi_scan.c
    +++ b/drivers/firmware/dmi_scan.c
    @@ -629,7 +629,7 @@ static int __init dmi_smbios3_present(const u8 *buf)
    {
    if (memcmp(buf, "_SM3_", 5) == 0 &&
    buf[6] < 32 && dmi_checksum(buf, buf[6])) {
    - dmi_ver = get_unaligned_be32(buf + 6) & 0xFFFFFF;
    + dmi_ver = get_unaligned_be24(buf + 7);
    dmi_num = 0; /* No longer specified */
    dmi_len = get_unaligned_le32(buf + 12);
    dmi_base = get_unaligned_le64(buf + 16);
    --
    2.35.1
    \
     
     \ /
      Last update: 2022-08-30 19:29    [W:3.994 / U:0.244 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site