Messages in this thread | | | From | Timur Tabi <> | Date | Tue, 30 Aug 2022 12:01:37 -0500 | Subject | Re: [PATCH v2 1/5] serial: ucc_uart: Remove custom frame size calculation |
| |
On Tue, Aug 30, 2022 at 3:49 AM Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> wrote: > > The number of bits can be calculated using tty_get_frame_size(), no > need for the driver to do it on its own. > > Also remove a comment on number of bits that doesn't match the code nor > the comment on ucc_uart_pram's rx_length ("minus 1" part differs). That > comment seems a verbatim copy of that in cpm_uart/cpm_uart_core.c > anyway so perhaps it was just copied over w/o much thinking. > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Acked-by: Timur Tabi <timur@kernel.org>
| |