lkml.org 
[lkml]   [2022]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/2] spi: dt-binding: add Microchip CoreQSPI compatible
From
On 02/08/2022 15:13, Mark Brown wrote:
> On Tue, Aug 02, 2022 at 10:52:25AM +0200, Krzysztof Kozlowski wrote:
>> On 01/08/2022 11:42, Naga Sureshkumar Relli wrote:
>
>>> - enum:
>>> - - microchip,mpfs-spi
>>> - - microchip,mpfs-qspi
>>> + oneOf:
>>> + - description: Microchip's Polarfire SoC SPI controller.
>>> + const: microchip,mpfs-spi
>>> + - description: Microchip's Polarfire SoC QSPI controller.
>
>> Useless descriptions - they repeat compatible. Just keep it as enum and
>> skip descriptions. What value do they bring?
>
> Someone not familiar with the full Microchip product line might not be
> aware of the expansion of mpfs, it's not blindingly obvious.

Then it should be explained in title/description of the binding, not in
compatible. This is the usual way of providing some text description,
not for each compatible by repeating the compatible text.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-08-03 08:12    [W:0.113 / U:1.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site