Messages in this thread | | | Date | Wed, 3 Aug 2022 19:14:16 +0200 | Subject | Re: [PATCH] tools/thermal: Fix possible path truncations | From | Daniel Lezcano <> |
| |
On 03/08/2022 19:07, Rafael J. Wysocki wrote: > On Mon, Jul 25, 2022 at 7:38 PM Florian Fainelli <f.fainelli@gmail.com> wrote: >> >> A build with -D_FORTIFY_SOURCE=2 enabled will produce the following warnings: >> >> sysfs.c:63:30: warning: '%s' directive output may be truncated writing up to 255 bytes into a region of size between 0 and 255 [-Wformat-truncation=] >> snprintf(filepath, 256, "%s/%s", path, filename); >> ^~ >> Bump up the buffer to PATH_MAX which is the limit and account for all of >> the possible NUL and separators that could lead to exceeding the >> allocated buffer sizes. >> >> Fixes: 94f69966faf8 ("tools/thermal: Introduce tmon, a tool for thermal subsystem") >> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > > Daniel, are you going to pick up this one or should I? > > There is also a tmon patch from Florian that seems to be pending. > Should I take care of it?
Mmh, let me check. I thought I picked them :/
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |