lkml.org 
[lkml]   [2022]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] selftests: kvm: Fix a compile error in selftests/kvm/rseq_test.c
My ldd version is (GNU libc) 2.28, and I get a compilation error in this case.
But I use another ldd (Ubuntu GLIBC 2.31-0ubuntu9.2) 2.31 is compiling fine.
This shows that compilation errors may occur in different GNU libc environments.
Would it be more appropriate to use syscall for better compatibility?

Thanks,
Jinrong Liang

Andrew Jones <andrew.jones@linux.dev> 于2022年8月2日周二 23:08写道:

>
> On Tue, Aug 02, 2022 at 03:12:40PM +0800, Jinrong Liang wrote:
> > From: Jinrong Liang <cloudliang@tencent.com>
> >
> > The following warning appears when executing:
> > make -C tools/testing/selftests/kvm
> >
> > rseq_test.c: In function ‘main’:
> > rseq_test.c:237:33: warning: implicit declaration of function ‘gettid’; did you mean ‘getgid’? [-Wimplicit-function-declaration]
> > (void *)(unsigned long)gettid());
> > ^~~~~~
> > getgid
> > /usr/bin/ld: /tmp/ccr5mMko.o: in function `main':
> > ../kvm/tools/testing/selftests/kvm/rseq_test.c:237: undefined reference to `gettid'
> > collect2: error: ld returned 1 exit status
> > make: *** [../lib.mk:173: ../kvm/tools/testing/selftests/kvm/rseq_test] Error 1
>
> The man page says we need
>
> #define _GNU_SOURCE
> #include <unistd.h>
>
> which rseq_test.c doesn't have. We have _GNU_SOURCE, but not unistd.h.
> IOW, I think this patch can be
>
> diff --git a/tools/testing/selftests/kvm/rseq_test.c b/tools/testing/selftests/kvm/rseq_test.c
> index a54d4d05a058..8d3d5eab5e19 100644
> --- a/tools/testing/selftests/kvm/rseq_test.c
> +++ b/tools/testing/selftests/kvm/rseq_test.c
> @@ -9,6 +9,7 @@
> #include <string.h>
> #include <signal.h>
> #include <syscall.h>
> +#include <unistd.h>
> #include <sys/ioctl.h>
> #include <sys/sysinfo.h>
> #include <asm/barrier.h>
>
> Thanks,
> drew
>
> >
> > Use the more compatible syscall(SYS_gettid) instead of gettid() to fix it.
> > More subsequent reuse may cause it to be wrapped in a lib file.
> >
> > Signed-off-by: Jinrong Liang <cloudliang@tencent.com>
> > ---
> > tools/testing/selftests/kvm/rseq_test.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/kvm/rseq_test.c b/tools/testing/selftests/kvm/rseq_test.c
> > index a54d4d05a058..299d316cc759 100644
> > --- a/tools/testing/selftests/kvm/rseq_test.c
> > +++ b/tools/testing/selftests/kvm/rseq_test.c
> > @@ -229,7 +229,7 @@ int main(int argc, char *argv[])
> > ucall_init(vm, NULL);
> >
> > pthread_create(&migration_thread, NULL, migration_worker,
> > - (void *)(unsigned long)gettid());
> > + (void *)(unsigned long)syscall(SYS_gettid));
> >
> > for (i = 0; !done; i++) {
> > vcpu_run(vcpu);
> > --
> > 2.37.1
> >

\
 
 \ /
  Last update: 2022-08-03 16:00    [W:0.522 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site