lkml.org 
[lkml]   [2022]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/numa: Use cpumask_available instead of hardcoded NULL check
On Wed, 03 Aug 2022 15:12:11 +0530  Ingo Molnar <mingo@kernel.org> wrote:
> Oh. So I was daft, as suspected. ;-)
>
> And I can confirm that while gcc-11 doesn't trigger the warning, gcc-12
> does:
>
> $ make ARCH=x86_64 CC=gcc-11 arch/x86/mm/numa.o
> CC arch/x86/mm/numa.o
> $
>
> $ rm -f arch/x86/mm/numa.o
> $
> $ make ARCH=x86_64 CC=gcc-12 arch/x86/mm/numa.o
>
> CC arch/x86/mm/numa.o
> arch/x86/mm/numa.c: In function ‘cpumask_of_node’:
> arch/x86/mm/numa.c:916:39: error: the comparison will always evaluate as ‘false’ for the address of ‘node_to_cpumask_map’ will never be NULL [-Werror=address]
> 916 | if (node_to_cpumask_map[node] == NULL) {
>
>
> > [...]
>
> Yeah - and I agree with your fix - will apply it.
>
> Thanks for your patience :-)
>
> Ingo
>

No worries, and thanks! :)
Siddh

\
 
 \ /
  Last update: 2022-08-03 11:47    [W:0.043 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site