Messages in this thread | | | Subject | Re: [PATCH v5 1/22] x86/virt/tdx: Detect TDX during kernel boot | From | Kai Huang <> | Date | Wed, 03 Aug 2022 21:25:16 +1200 |
| |
On Tue, 2022-08-02 at 10:01 +0800, Wu, Binbin wrote: > On 2022/6/22 19:15, Kai Huang wrote: > > + /* > > + * TDX guarantees at least two TDX KeyIDs are configured by > > + * BIOS, otherwise SEAMRR is disabled. Invalid TDX private > > + * range means kernel bug (TDX is broken). > > + */ > > + if (WARN_ON(!tdx_keyid_start || tdx_keyid_num < 2)) { > Do you think it's better to define a meaningful macro instead of the > number here and below? > >
Personally I don't think we need a macro. The comment already said "two", so having a macro doesn't help readability here (and below). But I am open on this.
-- Thanks, -Kai
| |