lkml.org 
[lkml]   [2022]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 00/13] PM6125 regulator support
From

>>
>> Iskren Chernev (13):
>> dt-bindings: regulator: qcom_spmi: Improve formatting of if-then
>> blocks
>> dt-bindings: regulator: qcom_spmi: Document PM6125 PMIC
>> dt-bindings: regulator: qcom_smd: Sort compatibles alphabetically
>> dt-bindings: regulator: qcom_smd: Document PM6125 PMIC
>> regulator: qcom_spmi: Add support for new regulator types
>> regulator: qcom_spmi: Add support for HFSMPS regulator type
>> regulator: qcom_spmi: Sort pmics alphabetically (part 1)
>> regulator: qcom_spmi: Sort pmics alphabetically (part 2)
>> regulator: qcom_spmi: Add PM6125 PMIC support
>> regulator: qcom_smd: Sort pmics alphabetically (part 1)
>> regulator: qcom_smd: Sort pmics alphabetically (part 2)
>> regulator: qcom_smd: Sort pmics alphabetically (part 3)
>
> What is the reason for these part1/2 and part1/2/3 splits? I think you can collapse them into two respective patches, one sorting of spmi, another one sorting the smd regulators

The reason is that if I do collapse them the diff looks much more
complicated and it's not obvious that the sections are in-fact only moved.
I'm not sure how these are reviewed, but casually reading the patch will
not instill confidence.

\
 
 \ /
  Last update: 2022-08-03 10:59    [W:0.166 / U:1.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site