Messages in this thread | | | Date | Wed, 3 Aug 2022 09:30:33 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v8 17/31] rust: add `kernel` crate |
| |
On Tue, Aug 02, 2022 at 04:53:17PM +0200, Miguel Ojeda wrote: > On Tue, Aug 2, 2022 at 4:36 PM Greg Kroah-Hartman > <gregkh@linuxfoundation.org> wrote: > > > > I did? Maybe I didn't realize we would end up with 15k lines of code > > from different parts of the kernel like amba bus and filesystem apis all > > in a single commit. If so, my fault, but as other parts of this > > discussion show, it is going to be required to get the subsystem > > maintainers to be able to review the interfaces to their code in order > > to get any further. > > No worries at all! Probably a misunderstanding on my side too. > > I am more than happy to spit it into quite a few patches, and it will > also help with the C-d-b's. > > As for reviewing -- since we keep adding abstractions and new features > to show how things may work, we would be chasing new reviews all the > time. Would it be better to drop some of those for the moment and get > the "core" in first?
Yes, it would be good to drop almost all of these for now, anything you do not have an in-tree user for, should not be present in anything you submit upstream.
> That way we can merge each subsystem part by part later, send it to > the proper MLs as smaller patches, get maintainers on board, etc. > etc., and it would be more manageable for everyone.
Yes, that would be the normal review process.
thanks,
greg k-h
| |