lkml.org 
[lkml]   [2022]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 16/41] drm/modes: Fill drm_cmdline mode from named modes
    Date
    The current code to deal with named modes will only set the mode name, and
    then it's up to drivers to try to match that name to whatever mode or
    configuration they see fit.

    The plan is to remove that need and move the named mode handling out of
    drivers and into the core, and only rely on modes and properties. Let's
    start by properly filling drm_cmdline_mode from a named mode.

    Signed-off-by: Maxime Ripard <maxime@cerno.tech>

    diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
    index 1fdfa004b139..5e898699b532 100644
    --- a/drivers/gpu/drm/drm_modes.c
    +++ b/drivers/gpu/drm/drm_modes.c
    @@ -2208,11 +2208,22 @@ static int drm_mode_parse_cmdline_options(const char *str,

    struct drm_named_mode {
    const char *name;
    + unsigned int xres;
    + unsigned int yres;
    + unsigned int flags;
    };

    +#define NAMED_MODE(_name, _x, _y, _flags) \
    + { \
    + .name = _name, \
    + .xres = _x, \
    + .yres = _y, \
    + .flags = _flags, \
    + }
    +
    static const struct drm_named_mode drm_named_modes[] = {
    - { "NTSC", },
    - { "PAL", },
    + NAMED_MODE("NTSC", 720, 480, DRM_MODE_FLAG_INTERLACE),
    + NAMED_MODE("PAL", 720, 576, DRM_MODE_FLAG_INTERLACE),
    };

    static int drm_mode_parse_cmdline_named_mode(const char *name,
    @@ -2254,6 +2265,9 @@ static int drm_mode_parse_cmdline_named_mode(const char *name,
    continue;

    strcpy(cmdline_mode->name, mode->name);
    + cmdline_mode->xres = mode->xres;
    + cmdline_mode->yres = mode->yres;
    + cmdline_mode->interlace = !!(mode->flags & DRM_MODE_FLAG_INTERLACE);
    cmdline_mode->specified = true;

    return 1;
    --
    b4 0.10.0-dev-65ba7

    \
     
     \ /
      Last update: 2022-08-29 15:16    [W:3.102 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site