lkml.org 
[lkml]   [2022]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 087/158] ionic: clear broken state on generation change
    Date
    From: Shannon Nelson <snelson@pensando.io>

    [ Upstream commit 9cb9dadb8f45c67e4310e002c2f221b70312b293 ]

    There is a case found in heavy testing where a link flap happens just
    before a firmware Recovery event and the driver gets stuck in the
    BROKEN state. This comes from the driver getting interrupted by a FW
    generation change when coming back up from the link flap, and the call
    to ionic_start_queues() in ionic_link_status_check() fails. This can be
    addressed by having the fw_up code clear the BROKEN bit if seen, rather
    than waiting for a user to manually force the interface down and then
    back up.

    Fixes: 9e8eaf8427b6 ("ionic: stop watchdog when in broken state")
    Signed-off-by: Shannon Nelson <snelson@pensando.io>
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/pensando/ionic/ionic_lif.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
    index 1443f788ee37c..d4226999547e8 100644
    --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
    +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
    @@ -2963,6 +2963,9 @@ static void ionic_lif_handle_fw_up(struct ionic_lif *lif)

    mutex_lock(&lif->queue_lock);

    + if (test_and_clear_bit(IONIC_LIF_F_BROKEN, lif->state))
    + dev_info(ionic->dev, "FW Up: clearing broken state\n");
    +
    err = ionic_qcqs_alloc(lif);
    if (err)
    goto err_unlock;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-29 14:17    [W:4.128 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site