lkml.org 
[lkml]   [2022]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] wifi: cfg80211: add error code in brcmf_notify_sched_scan_results()
From
Date


在 2022年08月29日 16:51, Arend Van Spriel 写道:
> On 8/29/2022 8:58 AM, Li Qiong wrote:
>> The err code is 0 at the first two "out_err" paths, add error code
>> '-EINVAL' for these error paths.
>
> There is no added value provided in this change. There is an error message, but it is otherwise silently ignored as there is no additional fault handling required.
It should be better to fix the return code, and It seems that the code has been checked, eg:
if (ifp->drvr->fweh.evt_handler[i]) {
.....
}


>
> Regards,
> Arend
>
>> Signed-off-by: Li Qiong <liqiong@nfschina.com>
>> ---
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 ++
>> 1 file changed, 2 insertions(+)

\
 
 \ /
  Last update: 2022-08-29 14:16    [W:0.058 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site