lkml.org 
[lkml]   [2022]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 78/86] md: call __md_stop_writes in md_stop
    Date
    From: Guoqing Jiang <guoqing.jiang@linux.dev>

    commit 0dd84b319352bb8ba64752d4e45396d8b13e6018 upstream.

    >From the link [1], we can see raid1d was running even after the path
    raid_dtr -> md_stop -> __md_stop.

    Let's stop write first in destructor to align with normal md-raid to
    fix the KASAN issue.

    [1]. https://lore.kernel.org/linux-raid/CAPhsuW5gc4AakdGNdF8ubpezAuDLFOYUO_sfMZcec6hQFm8nhg@mail.gmail.com/T/#m7f12bf90481c02c6d2da68c64aeed4779b7df74a

    Fixes: 48df498daf62 ("md: move bitmap_destroy to the beginning of __md_stop")
    Reported-by: Mikulas Patocka <mpatocka@redhat.com>
    Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev>
    Signed-off-by: Song Liu <song@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/md/md.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/md/md.c
    +++ b/drivers/md/md.c
    @@ -6299,6 +6299,7 @@ void md_stop(struct mddev *mddev)
    /* stop the array and free an attached data structures.
    * This is called from dm-raid
    */
    + __md_stop_writes(mddev);
    __md_stop(mddev);
    bioset_exit(&mddev->bio_set);
    bioset_exit(&mddev->sync_set);

    \
     
     \ /
      Last update: 2022-08-29 14:13    [W:2.813 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site