Messages in this thread | | | Date | Mon, 29 Aug 2022 09:09:03 +0300 | Subject | Re: [pinchartl-media:drm/du/next 13/14] drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c:614:6: warning: no previous prototype for function 'rcar_mipi_dsi_pclk_enable' | From | Tomi Valkeinen <> |
| |
On 28/08/2022 19:54, Laurent Pinchart wrote: > Hi Tomi, > > On Sun, Aug 28, 2022 at 08:52:39PM +0800, kernel test robot wrote: >> tree: git://linuxtv.org/pinchartl/media.git drm/du/next >> head: 1a1ef49313becc3127e3bd2b6cdb27e5fc54f761 >> commit: 81c238208c6accde5592851b101986b8b91ec859 [13/14] drm: rcar-du: Fix DSI enable & disable sequence >> config: riscv-randconfig-c006-20220828 (https://download.01.org/0day-ci/archive/20220828/202208282000.MtTNOyOx-lkp@intel.com/config) >> compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project a2100daf12fb980a29fd1a9c85ccf8eaaaf79730) >> reproduce (this is a W=1 build): >> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >> chmod +x ~/bin/make.cross >> # install riscv cross compiling tool for clang build >> # apt-get install binutils-riscv-linux-gnu >> git remote add pinchartl-media git://linuxtv.org/pinchartl/media.git >> git fetch --no-tags pinchartl-media drm/du/next >> git checkout 81c238208c6accde5592851b101986b8b91ec859 >> # save the config file >> mkdir build_dir && cp config build_dir/.config >> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/gpu/drm/rcar-du/ >> >> If you fix the issue, kindly add following tag where applicable >> Reported-by: kernel test robot <lkp@intel.com> >> >> All warnings (new ones prefixed by >>): >> >>>> drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c:614:6: warning: no previous prototype for function 'rcar_mipi_dsi_pclk_enable' [-Wmissing-prototypes] >> void rcar_mipi_dsi_pclk_enable(struct drm_bridge *bridge, >> ^ >> drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c:614:1: note: declare 'static' if the function is not intended to be used outside of this translation unit >> void rcar_mipi_dsi_pclk_enable(struct drm_bridge *bridge, >> ^ >> static >>>> drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c:653:6: warning: no previous prototype for function 'rcar_mipi_dsi_pclk_disable' [-Wmissing-prototypes] >> void rcar_mipi_dsi_pclk_disable(struct drm_bridge *bridge) >> ^ >> drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c:653:1: note: declare 'static' if the function is not intended to be used outside of this translation unit >> void rcar_mipi_dsi_pclk_disable(struct drm_bridge *bridge) >> ^ >> static >> 2 warnings generated. > > I'll squash the following fix in "drm: rcar-du: Fix DSI enable & disable > sequence": > > diff --git a/drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c b/drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c > index 90128d5e3d17..a7f2b7f66a17 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c > +++ b/drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c > @@ -25,6 +25,7 @@ > #include <drm/drm_panel.h> > #include <drm/drm_probe_helper.h> > > +#include "rcar_mipi_dsi.h" > #include "rcar_mipi_dsi_regs.h" > > struct rcar_mipi_dsi { >
Looks good to me.
Tomi
| |