lkml.org 
[lkml]   [2022]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 088/158] ionic: fix up issues with handling EAGAIN on FW cmds
    Date
    From: Shannon Nelson <snelson@pensando.io>

    [ Upstream commit 0fc4dd452d6c14828eed6369155c75c0ac15bab3 ]

    In looping on FW update tests we occasionally see the
    FW_ACTIVATE_STATUS command fail while it is in its EAGAIN loop
    waiting for the FW activate step to finsh inside the FW. The
    firmware is complaining that the done bit is set when a new
    dev_cmd is going to be processed.

    Doing a clean on the cmd registers and doorbell before exiting
    the wait-for-done and cleaning the done bit before the sleep
    prevents this from occurring.

    Fixes: fbfb8031533c ("ionic: Add hardware init and device commands")
    Signed-off-by: Shannon Nelson <snelson@pensando.io>
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/pensando/ionic/ionic_main.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/pensando/ionic/ionic_main.c b/drivers/net/ethernet/pensando/ionic/ionic_main.c
    index 4029b4e021f86..56f93b0305519 100644
    --- a/drivers/net/ethernet/pensando/ionic/ionic_main.c
    +++ b/drivers/net/ethernet/pensando/ionic/ionic_main.c
    @@ -474,8 +474,8 @@ static int __ionic_dev_cmd_wait(struct ionic *ionic, unsigned long max_seconds,
    ionic_opcode_to_str(opcode), opcode,
    ionic_error_to_str(err), err);

    - msleep(1000);
    iowrite32(0, &idev->dev_cmd_regs->done);
    + msleep(1000);
    iowrite32(1, &idev->dev_cmd_regs->doorbell);
    goto try_again;
    }
    @@ -488,6 +488,8 @@ static int __ionic_dev_cmd_wait(struct ionic *ionic, unsigned long max_seconds,
    return ionic_error_to_errno(err);
    }

    + ionic_dev_cmd_clean(ionic);
    +
    return 0;
    }

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-29 13:28    [W:2.962 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site