lkml.org 
[lkml]   [2022]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 013/158] Revert "xfrm: update SA curlft.use_time"
    Date
    From: Antony Antony <antony.antony@secunet.com>

    [ Upstream commit 717ada9f10f2de8c4f4d72ad045f3b67a7ced715 ]

    This reverts commit af734a26a1a95a9fda51f2abb0c22a7efcafd5ca.

    The abvoce commit is a regression according RFC 2367. A better fix would be
    use x->lastused. Which will be propsed later.

    according to RFC 2367 use_time == sadb_lifetime_usetime.

    "sadb_lifetime_usetime
    For CURRENT, the time, in seconds, when association
    was first used. For HARD and SOFT, the number of
    seconds after the first use of the association until
    it expires."

    Fixes: af734a26a1a9 ("xfrm: update SA curlft.use_time")
    Signed-off-by: Antony Antony <antony.antony@secunet.com>
    Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/xfrm/xfrm_input.c | 1 -
    net/xfrm/xfrm_output.c | 1 -
    2 files changed, 2 deletions(-)

    diff --git a/net/xfrm/xfrm_input.c b/net/xfrm/xfrm_input.c
    index 144238a50f3d4..70a8c36f0ba6e 100644
    --- a/net/xfrm/xfrm_input.c
    +++ b/net/xfrm/xfrm_input.c
    @@ -669,7 +669,6 @@ int xfrm_input(struct sk_buff *skb, int nexthdr, __be32 spi, int encap_type)

    x->curlft.bytes += skb->len;
    x->curlft.packets++;
    - x->curlft.use_time = ktime_get_real_seconds();

    spin_unlock(&x->lock);

    diff --git a/net/xfrm/xfrm_output.c b/net/xfrm/xfrm_output.c
    index 555ab35cd119a..9a5e79a38c679 100644
    --- a/net/xfrm/xfrm_output.c
    +++ b/net/xfrm/xfrm_output.c
    @@ -534,7 +534,6 @@ static int xfrm_output_one(struct sk_buff *skb, int err)

    x->curlft.bytes += skb->len;
    x->curlft.packets++;
    - x->curlft.use_time = ktime_get_real_seconds();

    spin_unlock_bh(&x->lock);

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-29 13:13    [W:4.153 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site