Messages in this thread | | | Date | Mon, 29 Aug 2022 10:31:38 +0100 | Subject | Re: [PATCH v2] cpufreq: check only freq_table in __resolve_freq() | From | Lukasz Luba <> |
| |
On 8/23/22 19:02, Rafael J. Wysocki wrote: > On Tue, Aug 16, 2022 at 2:02 PM Lukasz Luba <lukasz.luba@arm.com> wrote: >> >> There is no need to check if the cpufreq driver implements callback >> cpufreq_driver::target_index. The logic in the __resolve_freq uses >> the frequency table available in the policy. It doesn't matter if the >> driver provides 'target_index' or 'target' callback. It just has to >> populate the 'policy->freq_table'. >> >> Thus, check only frequency table during the frequency resolving call. >> >> Acked-by: Viresh Kumar <viresh.kumar@linaro.org> >> Signed-off-by: Lukasz Luba <lukasz.luba@arm.com> >> --- >> Changes: >> v2: >> - collected ACK from Viresh >> - corrected patch description (Viresh) >> >> >> drivers/cpufreq/cpufreq.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c >> index 7820c4e74289..69b3d61852ac 100644 >> --- a/drivers/cpufreq/cpufreq.c >> +++ b/drivers/cpufreq/cpufreq.c >> @@ -532,7 +532,7 @@ static unsigned int __resolve_freq(struct cpufreq_policy *policy, >> >> target_freq = clamp_val(target_freq, policy->min, policy->max); >> >> - if (!cpufreq_driver->target_index) >> + if (!policy->freq_table) >> return target_freq; >> >> idx = cpufreq_frequency_table_target(policy, target_freq, relation); >> -- > > Applied as 6.0-rc material, thanks!
Thanks Rafael!
| |