Messages in this thread | | | From | Shinichiro Kawasaki <> | Subject | Re: [PATCH] phy: marvell: phy-mvebu-a3700-comphy: Remove broken reset support | Date | Mon, 29 Aug 2022 09:02:12 +0000 |
| |
On Aug 29, 2022 / 10:30, Pali Rohár wrote: > Reset support for SATA PHY is somehow broken and after calling it, kernel > is not able to detect and initialize SATA disk Samsung SSD 850 EMT0 [1]. > > Reset support was introduced in commit 934337080c6c ("phy: marvell: > phy-mvebu-a3700-comphy: Add native kernel implementation") as part of > complete rewrite of this driver. v1 patch series of that commit [2] did > not contain reset support and was tested that is working fine with > Ethernet, SATA and USB PHYs without issues too. > > So for now remove broken reset support and change implementation of > power_off callback to power off all functions on specified lane (and not > only selected function) because during startup kernel does not know which > function was selected and configured by bootloader. Same logic was used > also in v1 patch series of that commit. > > This change fixes issues with initialization of SATA disk Samsung SSD 850 > and disk is working again, like before mentioned commit. > > Once problem with PHY reset callback is solved its functionality could be > re-introduced. But for now it is unknown why it does not work. > > [1] - https://lore.kernel.org/r/20220531124159.3e4lgn2v462irbtz@shindev/ > [2] - https://lore.kernel.org/r/20211028184242.22105-1-kabel@kernel.org/ > > Reported-by: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com> > Fixes: 934337080c6c ("phy: marvell: phy-mvebu-a3700-comphy: Add native kernel implementation") > Cc: stable@vger.kernel.org # v5.18+ > Signed-off-by: Pali Rohár <pali@kernel.org>
Pali, thanks for your care. I confirmed that this patch avoids the error I reported in the reference [1], and my SSD was detected on my espressobin board. Looks good.
Tested-by: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
-- Shin'ichiro Kawasaki
| |