Messages in this thread | | | Date | Mon, 29 Aug 2022 10:10:02 +0200 | From | Lorenzo Pieralisi <> | Subject | Re: [PATCH v3 1/6] reset: imx7: Add the iMX8MP PCIe PHY PERST support |
| |
On Thu, Aug 18, 2022 at 10:53:24AM +0000, Hongxing Zhu wrote: > > -----Original Message----- > > From: Philipp Zabel <p.zabel@pengutronix.de> > > Sent: 2022年8月18日 16:51 > > To: Hongxing Zhu <hongxing.zhu@nxp.com>; l.stach@pengutronix.de; > > bhelgaas@google.com; lorenzo.pieralisi@arm.com; robh@kernel.org; > > shawnguo@kernel.org; vkoul@kernel.org; alexander.stein@ew.tq-group.com; > > marex@denx.de > > Cc: linux-phy@lists.infradead.org; devicetree@vger.kernel.org; > > linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > linux-kernel@vger.kernel.org; kernel@pengutronix.de; dl-linux-imx > > <linux-imx@nxp.com> > > Subject: Re: [PATCH v3 1/6] reset: imx7: Add the iMX8MP PCIe PHY PERST > > support > > > > Hi Richard, > > > > On Do, 2022-08-18 at 15:02 +0800, Richard Zhu wrote: > > > On i.MX7/iMX8MM/iMX8MQ, the initialized default value of PERST > > > bit(BIT3) of SRC_PCIEPHY_RCR is 1b'1. > > > But i.MX8MP has one inversed default value 1b'0 of PERST bit. > > > > > > And the PERST bit should be kept 1b'1 after power and clocks are stable. > > > So add the i.MX8MP PCIe PHY PERST support here. > > > > the description is good now. It would be nice if this could also be mentioned in > > the Reference Manual. > > > > Please replace "add" with "fix" in the subject, as I requested earlier: > > "reset: imx7: Fix i.MX8MP PCIe PHY PERST support". > > > > And add a fixes line: > > > > Fixes: e08672c03981 ("reset: imx7: Add support for i.MX8MP SoC") > > > > With those two changes, > > Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> > > > Hi Philipp: > Okay, would be changed in next version.
AFAICS there is still a pending comment on patch (2) but I will mark this as "Changes requested" and wait for the next version.
Lorenzo
> Thanks for your review. > > Best Regards > Richard Zhu > > > regards > > Philipp > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
| |