Messages in this thread | | | Subject | Re: [PATCH v2 13/16] hwmon: (mr75203) add thermal coefficient properties for Moortec PVT controller | Date | Mon, 29 Aug 2022 21:46:32 +0300 | From | "Farber, Eliav" <> |
| |
On 8/22/2022 7:25 PM, Guenter Roeck wrote: > On Mon, Aug 22, 2022 at 04:24:20PM +0300, Farber, Eliav wrote: >> On 8/18/2022 11:25 PM, Guenter Roeck wrote: >> > On Wed, Aug 17, 2022 at 05:43:18AM +0000, Eliav Farber wrote: >> > > Add optional "ts-coeff-g", "ts-coeff-h", "ts-coeff-cal5" and >> > > "ts-coeff-j" properties to be used instead of defaults for the >> > > thermal equasion. >> > > >> > Vendor prefix again, and shouldn;t there be some note about the >> > to-be-used defaults ? >> Can you please explain why to add a vendor prefix to these properties >> (and also to all other properties I added in this series)? >> All the properties I added are not specific to our SOC, and any other >> vendor using the same mr75203 ip block in their SOC, can also use the >> new >> properties. > > To me it seems that the properties are very mr75203 and thus vendor > specific. > > However, I am not a DT maintainer. Stepping back to let DT maintainers > respond and state their preferences.
I added "moortec" prefix to all the new properties I added in this series. Will be part of v3.
-- Thanks, Eliav
| |