lkml.org 
[lkml]   [2022]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 10/31] net/tcp: Calculate TCP-AO traffic keys (fwd)
From
On 8/27/22 15:31, Julia Lawall wrote:
> Please check the kfree on lie 332.

Hmm, I don't see anything criminal here, but I can do for version 2:

:--- a/net/ipv4/tcp_ao.c
:+++ b/net/ipv4/tcp_ao.c
:@@ -939,8 +939,8 @@ void tcp_ao_connect_init(struct sock *sk)
: ao_info->snd_sne_seq = tp->write_seq;
: } else {
: WARN_ON_ONCE(1);
:- kfree(tp->ao_info);
: rcu_assign_pointer(tp->ao_info, NULL);
:+ kfree(ao_info);
: }
: }

just to make static analyzer happy. This part of the code is anyway
under WARN_ON_ONCE(), so it's not something that actually runs (as long
as the code is consistent, it's only error-path to free memory if some
code checks become broken in future, to avoid leaks even than).

Thanks,
Dmitry

\
 
 \ /
  Last update: 2022-08-29 20:23    [W:0.041 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site