Messages in this thread | | | From | Huacai Chen <> | Date | Mon, 29 Aug 2022 23:02:11 +0800 | Subject | Re: [PATCH v6 0/6] LoongArch: Support toolchain with new relocation types |
| |
Hi, Ruoyao,
This version looks good to me, only some small issues. Thank you very much.
Huacai
On Mon, Aug 29, 2022 at 10:57 PM Xi Ruoyao <xry111@xry111.site> wrote: > > On Mon, 2022-08-29 at 21:31 +0800, Xi Ruoyao wrote: > > > Changes from v5 to v6: > > > > - Restore version number. > > - Rename CONFIG_CC_HAS_EXPLICIT_RELOCS to > > CONFIG_AS_HAS_EXPLICIT_RELOCS. > > It now only checks assembler. > > - No longer support "old GCC with new Binutils", so R_LARCH_ABS* is > > dropped. > > - "Old GCC with old Binutils" is still supported until Arnd ack. > > > longer support it. > ^^^^ > This line should be removed :(. > > > - "New GCC with old Binutils" is still supported as it does not > > require additional code. > > - Remove "cc-option" around "-mexplicit-relocs". For unsupported > > "old GCC with new Binutils" combination, forcing -mexplicit-relocs > > makes assembling fail, instead of silently producing unloadable > > modules. > > - Move the error report for "lacking model attribute" into Makefile. > > - Squash the two patches for R_LARCH_B26 and R_LARCH_PCALA* into one. > > -- > Xi Ruoyao <xry111@xry111.site> > School of Aerospace Science and Technology, Xidian University
| |