lkml.org 
[lkml]   [2022]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 06/10] input: keyboard: adp5588-keys: do not check for irq presence
    Date
    There's no need for an extra check for 'client-irq'. Just let it fail when
    calling 'request_irq()'.

    Signed-off-by: Nuno Sá <nuno.sa@analog.com>
    Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
    ---
    drivers/input/keyboard/adp5588-keys.c | 5 -----
    1 file changed, 5 deletions(-)

    diff --git a/drivers/input/keyboard/adp5588-keys.c b/drivers/input/keyboard/adp5588-keys.c
    index 2b00bc0f174c..e716efbb2105 100644
    --- a/drivers/input/keyboard/adp5588-keys.c
    +++ b/drivers/input/keyboard/adp5588-keys.c
    @@ -727,11 +727,6 @@ static int adp5588_probe(struct i2c_client *client,
    return -EIO;
    }

    - if (!client->irq) {
    - dev_err(&client->dev, "no IRQ?\n");
    - return -EINVAL;
    - }
    -
    kpad = devm_kzalloc(&client->dev, sizeof(*kpad), GFP_KERNEL);
    if (!kpad)
    return -ENOMEM;
    --
    2.37.2
    \
     
     \ /
      Last update: 2022-08-29 16:08    [W:2.404 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site