Messages in this thread | | | From | Rob Herring <> | Subject | Re: [PATCH net-next 1/5] dt-bindings: net: Convert Altera TSE bindings to yaml | Date | Sun, 28 Aug 2022 09:21:16 -0500 |
| |
On Fri, 26 Aug 2022 15:54:47 +0200, Maxime Chevallier wrote: > This converts the bindings for the Altera Triple-Speed Ethernet to yaml. > > Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com> > --- > .../devicetree/bindings/net/altera_tse.txt | 113 --------------- > .../devicetree/bindings/net/altr,tse.yaml | 134 ++++++++++++++++++ > 2 files changed, 134 insertions(+), 113 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/net/altera_tse.txt > create mode 100644 Documentation/devicetree/bindings/net/altr,tse.yaml >
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/altr,tse.yaml: allOf:1:then:properties:reg-names: {'maxItems': 4, 'items': [{'const': 'control_port'}, {'const': 'rx_csr'}, {'const': 'tx_csr'}, {'const': 's1'}]} should not be valid under {'required': ['maxItems']} hint: "maxItems" is not needed with an "items" list from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/altr,tse.yaml: allOf:2:then:properties:reg-names: 'oneOf' conditional failed, one must be fixed: [{'const': 'control_port'}, {'const': 'rx_csr'}, {'const': 'rx_desc'}, {'const': 'rx_resp'}, {'const': 'tx_csr'}, {'const': 'tx_desc'}] is too long [{'const': 'control_port'}, {'const': 'rx_csr'}, {'const': 'rx_desc'}, {'const': 'rx_resp'}, {'const': 'tx_csr'}, {'const': 'tx_desc'}] is too short False schema does not allow 6 1 was expected 6 is greater than the maximum of 2 6 is greater than the maximum of 3 6 is greater than the maximum of 4 6 is greater than the maximum of 5 hint: "minItems" is only needed if less than the "items" list length from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/altr,tse.yaml: ignoring, error in schema: allOf: 1: then: properties: reg-names Documentation/devicetree/bindings/net/altr,tse.example.dtb:0:0: /example-0/ethernet@1,00001000: failed to match any schema with compatible: ['altr,tse-msgdma-1.0'] Documentation/devicetree/bindings/net/altr,tse.example.dtb:0:0: /example-0/ethernet@1,00001000/mdio: failed to match any schema with compatible: ['altr,tse-mdio']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit.
| |