Messages in this thread | | | Subject | Re: [PATCH v2 4/4] pwm: sysfs: Utilize an array for polarity strings | From | Joe Perches <> | Date | Sun, 28 Aug 2022 09:46:14 -0400 |
| |
On Sun, 2022-08-28 at 09:40 +0300, Andy Shevchenko wrote: > On Sunday, August 28, 2022, Joe Perches <joe@perches.com> wrote: > > > On Fri, 2022-08-26 at 20:07 +0300, Andy Shevchenko wrote: > > > Code is smaller and looks nicer if we combine polarity strings > > > into an array. > > First of all, please remove unnecessary context when replying.
I am _very_ aware of context. I specifically left the code in.
> > It's less robust though as PWM_POLARITY_NORMAL and _INVERSED > > are now required to be 0 and 1. As the only 2 values in > > an enum they are, but that's not really guaranteed unless > > you read the enum definition. > > So, what do you suggest here and in many other similar places (yes, ABI > implied) in the kernel?
Leaving the code alone.
| |