lkml.org 
[lkml]   [2022]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] dm: Remove the unneeeded variable
Hi Shaomin,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v6.0-rc2]
[also build test ERROR on linus/master next-20220826]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Shaomin-Deng/dm-Remove-the-unneeeded-variable/20220828-004044
base: 1c23f9e627a7b412978b4e852793c5e3c3efc555
config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20220828/202208280213.3Ws9aJBm-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/fd20974ffc753b102401c766eb62117c276a1527
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Shaomin-Deng/dm-Remove-the-unneeeded-variable/20220828-004044
git checkout fd20974ffc753b102401c766eb62117c276a1527
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

In file included from include/linux/dm-dirty-log.h:16,
from drivers/md/dm-log.c:13:
drivers/md/dm-log.c: In function 'disk_status':
>> include/linux/device-mapper.h:615:22: error: 'sz' undeclared (first use in this function); did you mean 's8'?
615 | #define DMEMIT(x...) sz += ((sz >= maxlen) ? \
| ^~
drivers/md/dm-log.c:810:17: note: in expansion of macro 'DMEMIT'
810 | DMEMIT("3 %s %s %c", log->type->name, lc->log_dev->name,
| ^~~~~~
include/linux/device-mapper.h:615:22: note: each undeclared identifier is reported only once for each function it appears in
615 | #define DMEMIT(x...) sz += ((sz >= maxlen) ? \
| ^~
drivers/md/dm-log.c:810:17: note: in expansion of macro 'DMEMIT'
810 | DMEMIT("3 %s %s %c", log->type->name, lc->log_dev->name,
| ^~~~~~


vim +615 include/linux/device-mapper.h

0da336e5fab75c Alasdair G Kergon 2008-04-24 614
0da336e5fab75c Alasdair G Kergon 2008-04-24 @615 #define DMEMIT(x...) sz += ((sz >= maxlen) ? \
0da336e5fab75c Alasdair G Kergon 2008-04-24 616 0 : scnprintf(result + sz, maxlen - sz, x))
0da336e5fab75c Alasdair G Kergon 2008-04-24 617

--
0-DAY CI Kernel Test Service
https://01.org/lkp

\
 
 \ /
  Last update: 2022-08-27 20:37    [W:0.397 / U:1.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site