Messages in this thread | | | From | Yongqin Liu <> | Date | Sat, 27 Aug 2022 20:24:24 +0800 | Subject | Re: [PATCH 0/3] More ARM DMA ops cleanup |
| |
Hi, Robin, Christoph
With the changes landed in the mainline kernel, one problem is exposed with our out of tree pvr module. Like the source here[1], arm_dma_ops.sync_single_for_cpu is called in the format like the following: arm_dma_ops.sync_single_for_cpu(NULL, pStart, pEnd - pStart, DMA_FROM_DEVICE);
Not sure if you could give some suggestions on what I should do next to make the pvr module work again.
Thanks in advance!
[1]: https://android-git.linaro.org/kernel/omap-modules.git/tree/pvr/services4/srvkm/env/linux/osfunc.c?h=android-mainline#n4615
Thanks, Yongqin Liu
On Thu, 21 Apr 2022 at 22:35, Robin Murphy <robin.murphy@arm.com> wrote: > > On 2022-04-21 15:13, Christoph Hellwig wrote: > > On Thu, Apr 21, 2022 at 12:36:56PM +0100, Robin Murphy wrote: > >> Hi all, > >> > >> Thanks to Christoph's latest series, I'm reminded that, if we're going > >> to give the ARM DMA ops some cleanup this cycle, it's as good a time as > >> any to dust off these old patches and add them on top as well. I've > >> based these on the arm-dma-direct branch which I assume matches the > >> patches posted at [1]. > > > > All these do look sensible to me. But weren't you working on replacing > > the ARM iommu dma_ops with dma-іommu anyway? > > Yes, that's somewhat entangled with the IOMMU bus ops stuff, so I'll > probably get to the point of having to revisit it in a couple of months > or so. These patches are off the bottom of that stack from my first > attempt, where the aim was to make the current ops the same shape first > so that the switch is then easier to reason about (particularly in terms > of sounding out any issues with the hooking up of dev->dma_coherent, > although your series will now be taking most of the load off there). > > Cheers, > Robin.
-- Best Regards, Yongqin Liu --------------------------------------------------------------- #mailing list linaro-android@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-android
| |