lkml.org 
[lkml]   [2022]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] ASoC: codecs: allow compile testing without MFD drivers
From
On 26/08/2022 21:35, Mark Brown wrote:
> On Fri, Aug 26, 2022 at 12:36:59PM +0300, Krzysztof Kozlowski wrote:
>> Motorola CPCAP, Lochnagar Sound, Rockchip RK817 and Qualcomm
>> WCD9340/WCD9341 do not depend on parent MFD driver in build time and can
>> be compile tested without respective MFD part for increased build
>> coverage.
>
> Although generally it's easy enough to just turn on the MFDs
> themselves, it's not the same base platform issue as the firmware
> interfaces can be.

True, it's not the same build coverage need as subsystem/interface
dependencies, but still:
1. Drivers can be built independently, so why not?
2. There is no drawback in allowing to building them independently
(compile test).
3. The parent MFD device could also depend on something (RK817 and
MFD_LOCHNAGAR depends on I2C and OF; CPCAP on SPI), so it's not always
the case of just enabling parent. IOW, you can compile test codecs
without I2C and SPI which is valuable itself.

I find the last reason actually quite valid and applicable here. If you
wish I can add it to the commit msg.


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-08-27 11:03    [W:0.243 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site