Messages in this thread | | | Date | Fri, 26 Aug 2022 21:17:29 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH v5 04/44] x86: asm: instrument usercopy in get_user() and put_user() |
| |
On Fri, 26 Aug 2022 17:07:27 +0200 Alexander Potapenko <glider@google.com> wrote:
> Use hooks from instrumented.h to notify bug detection tools about > usercopy events in variations of get_user() and put_user().
And this one blows up x86_64 allmodconfig builds.
> --- a/arch/x86/include/asm/uaccess.h > +++ b/arch/x86/include/asm/uaccess.h > @@ -5,6 +5,7 @@ > * User space memory access functions > */ > #include <linux/compiler.h> > +#include <linux/instrumented.h> > #include <linux/kasan-checks.h> > #include <linux/string.h> > #include <asm/asm.h>
instrumented.h looks like a higher-level thing than uaccess.h, so this inclusion is an inappropriate layering. Or maybe not.
In file included from ./include/linux/kernel.h:22, from ./arch/x86/include/asm/percpu.h:27, from ./arch/x86/include/asm/nospec-branch.h:14, from ./arch/x86/include/asm/paravirt_types.h:40, from ./arch/x86/include/asm/ptrace.h:97, from ./arch/x86/include/asm/math_emu.h:5, from ./arch/x86/include/asm/processor.h:13, from ./arch/x86/include/asm/timex.h:5, from ./include/linux/timex.h:67, from ./include/linux/time32.h:13, from ./include/linux/time.h:60, from ./include/linux/stat.h:19, from ./include/linux/module.h:13, from init/do_mounts.c:2: ./include/linux/page-flags.h: In function 'page_fixed_fake_head': ./include/linux/page-flags.h:226:36: error: invalid use of undefined type 'const struct page' 226 | test_bit(PG_head, &page->flags)) { | ^~
[25000 lines snipped]
And kmsan-add-kmsan-runtime-core.patch introduces additional build errors with x86_64 allmodconfig.
This is all with CONFIG_KMSAN=n
I'll disable the patch series. Please do much more compilation testing - multiple architectures, allnoconfig, allmodconfig, allyesconfig, defconfig, randconfig, etc. Good luck, it looks ugly :(
| |