Messages in this thread | | | Date | Fri, 26 Aug 2022 07:37:06 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v4] cachefiles: fix error return code in cachefiles_ondemand_copen() |
| |
On Fri, Aug 26, 2022 at 10:35:15AM +0800, Sun Ke wrote: > The cache_size field of copen is specified by the user daemon. > If cache_size < 0, then the OPEN request is expected to fail, > while copen itself shall succeed. However, returning 0 is indeed > unexpected when cache_size is an invalid error code. > > Fix this by returning error when cache_size is an invalid error code. > > Fixes: c8383054506c ("cachefiles: notify the user daemon when looking up cookie") > Signed-off-by: Sun Ke <sunke32@huawei.com> > Suggested-by: Jeffle Xu <jefflexu@linux.alibaba.com> > Suggested-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > v4: update the code suggested by Dan > v3: update the commit log suggested by Jingbo.
Thanks!
regards, dan carpenter
| |