Messages in this thread | | | Date | Fri, 26 Aug 2022 13:10:18 +0530 | Subject | Re: [PATCH linux-next] rpmsg: char: Remove the unneeded result variable | From | Mukesh Ojha <> |
| |
On 8/26/2022 12:49 PM, cgel.zte@gmail.com wrote: > From: ye xingchen <ye.xingchen@zte.com.cn> > > Return the value rpmsg_chrdev_eptdev_add() directly instead of storing it > in another redundant variable. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn> > --- > drivers/rpmsg/rpmsg_char.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c > index 4f2189111494..0850ae34fb88 100644 > --- a/drivers/rpmsg/rpmsg_char.c > +++ b/drivers/rpmsg/rpmsg_char.c > @@ -424,15 +424,12 @@ int rpmsg_chrdev_eptdev_create(struct rpmsg_device *rpdev, struct device *parent > struct rpmsg_channel_info chinfo) > { > struct rpmsg_eptdev *eptdev; > - int ret; > > eptdev = rpmsg_chrdev_eptdev_alloc(rpdev, parent); > if (IS_ERR(eptdev)) > return PTR_ERR(eptdev); > > - ret = rpmsg_chrdev_eptdev_add(eptdev, chinfo); > - > - return ret; > + return rpmsg_chrdev_eptdev_add(eptdev, chinfo); > }
LGTM.
Reviewed-by:Mukesh Ojha <quic_mojha@quicinc.com>
-Mukesh
> EXPORT_SYMBOL(rpmsg_chrdev_eptdev_create); >
| |