Messages in this thread | | | Subject | Re: [PATCH 10/10] hugetlb: make hugetlb selects SYSFS if !SYSCTL | From | Miaohe Lin <> | Date | Sat, 27 Aug 2022 10:34:30 +0800 |
| |
On 2022/8/27 9:59, Muchun Song wrote: > > >> On Aug 26, 2022, at 17:24, Miaohe Lin <linmiaohe@huawei.com> wrote: >> >> If CONFIG_SYSFS and CONFIG_SYSCTL are both undefined, hugetlb doesn't work >> now as there's no way to set max huge pages. Make sure at least one of the >> above configs is defined to make hugetlb works as expected. > > Right. I think the majority of the people are usually use /proc knob to > reserve HugeTLB pages than /sys fs. So I suggest to add a “depends on SYSCTL” > item. What’s your thoughts?
It seems some functions, e.g. demotion, is exported via SYSFS instead of SYSCTL. So maybe "depends on SYSFS || SYSCTL", i.e.
depends on (X86 || IA64 || SPARC64 || ARCH_SUPPORTS_HUGETLBFS || BROKEN) && (SYSFS || SYSCTL)
will be more suitable?
Thanks, Miaohe Lin
| |