Messages in this thread | | | From | Jonathan Corbet <> | Subject | Re: [PATCH net-next v2] docs/conf.py: add function attribute '__fix_address' to conf.py | Date | Fri, 26 Aug 2022 16:14:45 -0600 |
| |
Jonathan Corbet <corbet@lwn.net> writes:
> Jakub Kicinski <kuba@kernel.org> writes: > >> On Sat, 27 Aug 2022 00:01:50 +0800 menglong8.dong@gmail.com wrote: >>> From: Menglong Dong <imagedong@tencent.com> >>> >>> Stephen Rothwell reported htmldocs warning when merging net-next: >>> >>> Documentation/networking/kapi:26: net/core/skbuff.c:780: WARNING: Error in declarator or parameters >>> Invalid C declaration: Expecting "(" in parameters. [error at 19] >>> void __fix_address kfree_skb_reason (struct sk_buff *skb, enum skb_drop_reason reason) >>> -------------------^ >>> >>> Add __fix_address keyword to c_id_attributes array in conf.py to fix >>> the warning. >> >> You'll need to CC netdev@ for the patch to get into the net-next tree. >> Since this is a pure Documentation/ patch get_maintainer.pl did not >> produce netdev@ in the recommended addresses. >> >> Please wait for a review/ack from Jon before reposting, we need his >> permission to apply this patch. > > I could also just carry it through docs; I'm about to send a set of > fixes Linusward in any case. I wanted to run a couple of tests to be > sure, but I don't expect any problems with it...
The patch is clearly correct, it can go in via whatever path seems most suitable. Let me know if you'd like me to push it; otherwise:
Acked-by: Jonathan Corbet <corbet@lwn.net>
Thanks,
jon
| |