lkml.org 
[lkml]   [2022]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 00/18] Mutex wrapper, locking and memory leak fixes
Em Fri, Aug 26, 2022 at 12:08:06PM -0700, Namhyung Kim escreveu:
> On Fri, Aug 26, 2022 at 9:42 AM Ian Rogers <irogers@google.com> wrote:
> >
> > When fixing a locking race and memory leak in:
> > https://lore.kernel.org/linux-perf-users/20211118193714.2293728-1-irogers@google.com/
> >
> > It was requested that debug mutex code be separated out into its own
> > files. This was, in part, done by Pavithra Gurushankar in:
> > https://lore.kernel.org/lkml/20220727111954.105118-1-gpavithrasha@gmail.com/
> >
> > These patches fix issues with the previous patches, add in the
> > original dso->nsinfo fix and then build on our mutex wrapper with
> > clang's -Wthread-safety analysis. The analysis found missing unlocks
> > in builtin-sched.c which are fixed and -Wthread-safety is enabled by
> > default when building with clang.
> >
> > v4. Adds a comment for the trylock result, fixes the new line (missed
> > in v3) and removes two blank lines as suggested by Adrian Hunter.
> > v3. Adds a missing new line to the error messages and removes the
> > pshared argument to mutex_init by having two functions, mutex_init
> > and mutex_init_pshared. These changes were suggested by Adrian Hunter.
> > v2. Breaks apart changes that s/pthread_mutex/mutex/g and the lock
> > annotations as requested by Arnaldo and Namhyung. A boolean is
> > added to builtin-sched.c to terminate thread funcs rather than
> > leaving them blocked on delted mutexes.
> >
> > Ian Rogers (17):
> > perf bench: Update use of pthread mutex/cond
> > perf tests: Avoid pthread.h inclusion
> > perf hist: Update use of pthread mutex
> > perf bpf: Remove unused pthread.h include
> > perf lock: Remove unused pthread.h include
> > perf record: Update use of pthread mutex
> > perf sched: Update use of pthread mutex
> > perf ui: Update use of pthread mutex
> > perf mmap: Remove unnecessary pthread.h include
> > perf dso: Update use of pthread mutex
> > perf annotate: Update use of pthread mutex
> > perf top: Update use of pthread mutex
> > perf dso: Hold lock when accessing nsinfo
> > perf mutex: Add thread safety annotations
> > perf sched: Fixes for thread safety analysis
> > perf top: Fixes for thread safety analysis
> > perf build: Enable -Wthread-safety with clang
> >
> > Pavithra Gurushankar (1):
> > perf mutex: Wrapped usage of mutex and cond
>
> For the patches 1-7 and 10-13
>
> Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks added it, will try to get what is done so far merged and then we
can go on addressing the other issues brought up in this thread.

- Arnaldo

\
 
 \ /
  Last update: 2022-08-26 21:23    [W:0.081 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site