lkml.org 
[lkml]   [2022]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] arm64: dts: qcom: sc7280-herobrine: Don't enable the USB 2.0 port
From


On 26.08.2022 17:48, Matthias Kaehlcke wrote:
> The USB 2.0 port of sc7280 is currently not used by any herobrine
> board. Delete the device tree entries that enable it.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>

Konrad
> I was also told that the 2.0 port is for the Embedded USB Debugger
> (EUD) only, but I'm not sure if that's true. From the Linux side
> it looks like a regular dwc3 controller.
>
> arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> index 3f8996c00b05..b2f0404d3f71 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> @@ -606,18 +606,6 @@ &usb_1_qmpphy {
> status = "okay";
> };
>
> -&usb_2 {
> - status = "okay";
> -};
> -
> -&usb_2_dwc3 {
> - dr_mode = "host";
> -};
> -
> -&usb_2_hsphy {
> - status = "okay";
> -};
> -
> /* PINCTRL - ADDITIONS TO NODES IN PARENT DEVICE TREE FILES */
>
> &dp_hot_plug_det {

\
 
 \ /
  Last update: 2022-08-26 20:49    [W:0.070 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site