Messages in this thread | | | From | "Michael Kelley (LINUX)" <> | Subject | RE: [PATCH] hv/hv_kvp_daemon: remove unnecessary (void*) conversions | Date | Thu, 25 Aug 2022 17:14:55 +0000 |
| |
From: Zhou jie <zhoujie@nfschina.com> Sent: Monday, August 22, 2022 8:46 PM > > remove unnecessary void* type casting. > > Signed-off-by: Zhou jie <zhoujie@nfschina.com> > --- > tools/hv/hv_kvp_daemon.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c > index 1e6fd6ca513b..445abb53bf0d 100644 > --- a/tools/hv/hv_kvp_daemon.c > +++ b/tools/hv/hv_kvp_daemon.c > @@ -772,11 +772,11 @@ static int kvp_process_ip_address(void *addrp, > const char *str; > > if (family == AF_INET) { > - addr = (struct sockaddr_in *)addrp; > + addr = addrp; > str = inet_ntop(family, &addr->sin_addr, tmp, 50); > addr_length = INET_ADDRSTRLEN; > } else { > - addr6 = (struct sockaddr_in6 *)addrp; > + addr6 = addrp; > str = inet_ntop(family, &addr6->sin6_addr.s6_addr, tmp, 50); > addr_length = INET6_ADDRSTRLEN; > } > -- > 2.18.2
The patch subject prefix for changes to this module is usually "tools: hv:" or "tools: hv: kvp:" and this patch should be consistent. Check the commit log for tools/hv/hv_kvp_daemon.c for historical examples.
Modulo this tweak,
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
| |