lkml.org 
[lkml]   [2022]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6/7] arm64: dts: qcom: sm8250-xperia-edo: Specify which LDO modes are allowed
    Date
    This board uses RPMH, specifies "regulator-allow-set-load" for LDOs,
    but doesn't specify any modes with "regulator-allowed-modes".

    Prior to commit efb0cb50c427 ("regulator: qcom-rpmh: Implement
    get_optimum_mode(), not set_load()") the above meant that we were able
    to set either LPM or HPM mode. After that commit (and fixes [1]) we'll
    be stuck at the initial mode. Discussion of this has resulted in the
    decision that the old dts files were wrong and should be fixed to
    fully restore old functionality.

    Let's re-enable the old functionality by fixing the dts.

    [1] https://lore.kernel.org/r/20220824142229.RFT.v2.2.I6f77860e5cd98bf5c67208fa9edda4a08847c304@changeid

    Fixes: 69cdb97ef652 ("arm64: dts: qcom: sm8250: Add support for SONY Xperia 1 II / 5 II (Edo platform)")
    Signed-off-by: Douglas Anderson <dianders@chromium.org>
    ---

    arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 6 ++++++
    1 file changed, 6 insertions(+)

    diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
    index 549e0a2aa9fe..5428aab3058d 100644
    --- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
    +++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
    @@ -317,6 +317,9 @@ vreg_l6c_2p9: ldo6 {
    regulator-max-microvolt = <2960000>;
    regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
    regulator-allow-set-load;
    + regulator-allowed-modes =
    + <RPMH_REGULATOR_MODE_LPM
    + RPMH_REGULATOR_MODE_HPM>;
    };

    vreg_l7c_2p85: ldo7 {
    @@ -339,6 +342,9 @@ vreg_l9c_2p9: ldo9 {
    regulator-max-microvolt = <2960000>;
    regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
    regulator-allow-set-load;
    + regulator-allowed-modes =
    + <RPMH_REGULATOR_MODE_LPM
    + RPMH_REGULATOR_MODE_HPM>;
    };

    vreg_l10c_3p3: ldo10 {
    --
    2.37.2.672.g94769d06f0-goog
    \
     
     \ /
      Last update: 2022-08-25 18:44    [W:5.307 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site