Messages in this thread Patch in this message | | | From | Jack Wang <> | Subject | [PATCH 1/2] nvme-rdma: Fix error check for ib_dma_map_sg | Date | Thu, 25 Aug 2022 08:47:46 +0200 |
| |
ib_dma_map_sg return 0 on error.
Cc: Keith Busch <kbusch@kernel.org> Cc: Jens Axboe <axboe@fb.com> Cc: Christoph Hellwig <hch@lst.de> Cc: Sagi Grimberg <sagi@grimberg.me> Cc: linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org Fixes: 711023071960 ("nvme-rdma: add a NVMe over Fabrics RDMA host driver") Signed-off-by: Jack Wang <jinpu.wang@ionos.com> --- drivers/nvme/host/rdma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c index 3100643be299..d70bccbcba3e 100644 --- a/drivers/nvme/host/rdma.c +++ b/drivers/nvme/host/rdma.c @@ -1551,7 +1551,7 @@ static int nvme_rdma_dma_map_req(struct ib_device *ibdev, struct request *rq, *count = ib_dma_map_sg(ibdev, req->data_sgl.sg_table.sgl, req->data_sgl.nents, rq_dma_dir(rq)); - if (unlikely(*count <= 0)) { + if (unlikely(!*count)) { ret = -EIO; goto out_free_table; } @@ -1574,7 +1574,7 @@ static int nvme_rdma_dma_map_req(struct ib_device *ibdev, struct request *rq, req->metadata_sgl->sg_table.sgl, req->metadata_sgl->nents, rq_dma_dir(rq)); - if (unlikely(*pi_count <= 0)) { + if (unlikely(!*pi_count)) { ret = -EIO; goto out_free_pi_table; } -- 2.34.1
| |