Messages in this thread Patch in this message | | | From | Vincent Guittot <> | Subject | [PATCH 3/4] sched/fair: move call to list_last_entry() in detach_tasks | Date | Thu, 25 Aug 2022 14:27:25 +0200 |
| |
Move the call to list_last_entry() in detach_tasks() after testing loop_max and loop_break.
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org> --- kernel/sched/fair.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 6972a1a29a48..260a55ac462f 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -8047,8 +8047,6 @@ static int detach_tasks(struct lb_env *env) if (env->idle != CPU_NOT_IDLE && env->src_rq->nr_running <= 1) break; - p = list_last_entry(tasks, struct task_struct, se.group_node); - env->loop++; /* * We've more or less seen every task there is, call it quits @@ -8065,6 +8063,8 @@ static int detach_tasks(struct lb_env *env) break; } + p = list_last_entry(tasks, struct task_struct, se.group_node); + if (!can_migrate_task(p, env)) goto next; -- 2.17.1
| |