Messages in this thread | | | Date | Thu, 25 Aug 2022 13:21:13 +0100 | From | Mark Brown <> | Subject | Re: [PATCH v4] regulator: core: Resolve supply name earlier to prevent double-init |
| |
On Thu, Aug 25, 2022 at 01:32:50PM +0200, Marek Szyprowski wrote:
> This patch landed recently in linux next as commit 8a866d527ac0 > ("regulator: core: Resolve supply name earlier to prevent double-init"). > Unfortunately it breaks booting of Samsung Exynos 5800 based Peach-Pi > (arch/arm/boot/dts/exynos5800-peach-pi.dts) and Peach-Pit > (arch/arm/boot/dts/exynos5420-peach-pit.dts) Chromebooks. The last > message in the kernel log is a message about disabling 'vdd_1v2' > regulator. This regulator is not used directly, however it is a supply > for other critical regulators.
This suggests that supplies are ending up not getting bound. Could you perhaps add logging to check that we're attempting to resolve the supply (in the
+ if ((rdev->supply_name && !rdev->supply) && + (rdev->constraints->always_on || + rdev->constraints->boot_on)) {
block)? I'd also note that it's useful to paste the actual error messages you're seeing rather than just a description of them. [unhandled content-type:application/pgp-signature] | |