lkml.org 
[lkml]   [2022]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/1] Pinctrl: Add in zero check
On Thu, Aug 25, 2022 at 3:07 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> On Tue, Aug 16, 2022 at 11:09 AM Will Shiu <Will.Shiu@mediatek.com> wrote:
>
> > add in check of buffer offset to avoid the exception when input 0 size.
> >
> > Signed-off-by: Will Shiu <Will.Shiu@mediatek.com>
>
> Looks good to me, patch applied!

Sorry, but it seems the author didn't pay much attention and didn't
really work on it. What does the < 0 comparison mean here?

I would ask if there is _real_ issue with the code? What is the use
case and why is this check needed?

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2022-08-25 14:18    [W:2.056 / U:1.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site