Messages in this thread | | | From | Linus Walleij <> | Date | Thu, 25 Aug 2022 14:11:41 +0200 | Subject | Re: [PATCH v4 2/2] dt-bindings: pinctrl: samsung: deprecate header with register constants |
| |
On Tue, Aug 16, 2022 at 3:30 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> For convenience (less code duplication, some meaning added to raw > number), the pin controller pin configuration register values > were defined in the bindings header. These are not some IDs or other > abstraction layer but raw numbers used in the registers > > These constants do not fit the purpose of bindings. They do not provide > any abstraction, any hardware and driver independent ID. With minor > exceptions, the Linux drivers actually do not use the bindings header at > all. > > All of the constants were moved already to headers local to DTS > (residing in DTS directory) and to Samsung pinctrl driver (where > applicable), so remove any references to the bindings header and add a > warning tha tit is deprecated. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Reviewed-by: Chanho Park <chanho61.park@samsung.com> > Acked-by: Rob Herring <robh@kernel.org> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
I assume this will be queued to one or another of the Samsung trees, and I will get it by pull request. Just tell me if something else needs to happen!
Yours, Linus Walleij
| |